Skip to content

issue #82: Fixed MosaicService to pass single MosaicInfo object instead of array #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2019
Merged

issue #82: Fixed MosaicService to pass single MosaicInfo object instead of array #84

merged 3 commits into from
Mar 12, 2019

Conversation

@evias
Copy link
Contributor

@evias evias commented Mar 12, 2019

Fixes issue #82 : MosaicService is broken.

  • MosaicService.mosaicAmountView() must pass single instance of MosaicInfo instead of MosaicInfo[].

@coveralls
Copy link

coveralls commented Mar 12, 2019

Pull Request Test Coverage Report for Build 212

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.829%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/service/MosaicService.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 208: 0.0%
Covered Lines: 1012
Relevant Lines: 1290
💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 12, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 214

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 13 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.0%) to 70.836%
Files with Coverage Reduction New Missed Lines %
src/model/namespace/NamespaceId.ts 2 66.67%
src/infrastructure/NamespaceHttp.ts 3 16.83%
src/service/NamespaceService.ts 8 21.43%
Totals Coverage Status
Change from base Build 208: -1.0%
Covered Lines: 998
Relevant Lines: 1289
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@rg911 rg911 rg911 approved these changes

@dgarcia360 dgarcia360 dgarcia360 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@evias @coveralls @rg911 @dgarcia360